<html>
<head><meta charset="utf-8"><title>ICE with incorrect turbofish #60989 · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html">ICE with incorrect turbofish #60989</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="166364634"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166364634" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166364634">(May 23 2019 at 14:18)</a>:</h4>
<p>let's split a topic -- <span class="user-mention" data-user-id="124288">@oli</span> <span class="user-mention" data-user-id="121053">@varkor</span> <span class="user-mention" data-user-id="126931">@centril</span> <span class="user-mention" data-user-id="116083">@pnkfelix</span></p>



<a name="166364736"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166364736" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166364736">(May 23 2019 at 14:19)</a>:</h4>
<p><span class="user-mention" data-user-id="124288">@oli</span>  reduced some more: <a href="https://github.com/rust-lang/rust/issues/60989#issuecomment-495239018" target="_blank" title="https://github.com/rust-lang/rust/issues/60989#issuecomment-495239018">https://github.com/rust-lang/rust/issues/60989#issuecomment-495239018</a></p>



<a name="166364869"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166364869" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166364869">(May 23 2019 at 14:21)</a>:</h4>
<p>(<span class="user-mention" data-user-id="126931">@centril</span> I moved your message over here)</p>



<a name="166364920"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166364920" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166364920">(May 23 2019 at 14:21)</a>:</h4>
<p>so, to reiterate, if I'm the one running the release a patch has to be r+ed before 17 UTC, which is in ~1.5 hours</p>



<a name="166365088"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166365088" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166365088">(May 23 2019 at 14:22)</a>:</h4>
<p><span class="user-mention" data-user-id="124288">@oli</span> if you make a PR please target it to the stable branch directly, we'll forward port it later</p>



<a name="166365114"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166365114" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166365114">(May 23 2019 at 14:23)</a>:</h4>
<p>will do</p>



<a name="166365173"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166365173" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166365173">(May 23 2019 at 14:23)</a>:</h4>
<p>my working theory is that <code>prohibit_generics</code> is now not called anymore because the early return was moved up</p>



<a name="166365205"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166365205" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166365205">(May 23 2019 at 14:23)</a>:</h4>
<p><span class="user-mention" data-user-id="124288">@oli</span>  Reduced maximally:</p>
<div class="codehilite"><pre><span></span><span class="k">fn</span> <span class="nf">main</span><span class="p">()</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">    </span><span class="kd">let</span><span class="w"> </span><span class="n">c1</span><span class="w"> </span><span class="o">=</span><span class="w"> </span><span class="p">();</span><span class="w"></span>
<span class="w">    </span><span class="n">c1</span>::<span class="o">&lt;</span><span class="p">()</span><span class="o">&gt;</span><span class="p">;</span><span class="w"></span>
<span class="p">}</span><span class="w"></span>
</pre></div>



<a name="166365498"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166365498" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166365498">(May 23 2019 at 14:26)</a>:</h4>
<p>Ok, my theory is becoming certainty</p>



<a name="166365540"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166365540" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166365540">(May 23 2019 at 14:26)</a>:</h4>
<p>it's just nontrivial to fix :D I basically need to revert the PR that introduced the bug and fix self resolution <em>again</em></p>



<a name="166366310"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166366310" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166366310">(May 23 2019 at 14:34)</a>:</h4>
<p>I have to leave for around an hour -- once the PR is r+ed p=1000 it and <code>@bors retry</code> any other build currently running</p>



<a name="166368308"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166368308" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166368308">(May 23 2019 at 14:54)</a>:</h4>
<p>is the ICE from the PR that introduced the bug something that is less impactful than this ICE?</p>



<a name="166368325"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166368325" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166368325">(May 23 2019 at 14:55)</a>:</h4>
<p>in other words, would we be best off <strong>just</strong> reverting that PR for the short-term</p>



<a name="166368328"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166368328" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166368328">(May 23 2019 at 14:55)</a>:</h4>
<p>?</p>



<a name="166368458"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166368458" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166368458">(May 23 2019 at 14:56)</a>:</h4>
<p>reverting the PR would mean removing a run-pass test</p>



<a name="166368465"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166368465" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166368465">(May 23 2019 at 14:56)</a>:</h4>
<p>not a good idea</p>



<a name="166368618"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166368618" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166368618">(May 23 2019 at 14:58)</a>:</h4>
<p>it depends on the run-pass test</p>



<a name="166368660"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166368660" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166368660">(May 23 2019 at 14:58)</a>:</h4>
<p>(basically trying to weigh impact of one ICE vs another)</p>



<a name="166368679"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166368679" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166368679">(May 23 2019 at 14:59)</a>:</h4>
<p>We can't do a crater run to ascertain the breakage and it could break stable code</p>



<a name="166368732"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166368732" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166368732">(May 23 2019 at 14:59)</a>:</h4>
<p>look at this: <a href="https://github.com/rust-lang/rust/issues/57924#issuecomment-457892376" target="_blank" title="https://github.com/rust-lang/rust/issues/57924#issuecomment-457892376">https://github.com/rust-lang/rust/issues/57924#issuecomment-457892376</a></p>



<a name="166368785"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166368785" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166368785">(May 23 2019 at 15:00)</a>:</h4>
<p>the bug this was fixing was on-going for a number of releases</p>



<a name="166368819"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166368819" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166368819">(May 23 2019 at 15:00)</a>:</h4>
<p>(starting, IIUC, in 1.30)</p>



<a name="166368836"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166368836" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166368836">(May 23 2019 at 15:00)</a>:</h4>
<p>I think I have a fix, testing right now</p>



<a name="166368935"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166368935" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166368935">(May 23 2019 at 15:01)</a>:</h4>
<p>(in other words, I'm trying to say that I think <code>Self::&lt;stuff&gt;</code> occurs less often than <code>random_ident::&lt;stuff&gt;</code>)</p>



<a name="166368963"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166368963" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166368963">(May 23 2019 at 15:01)</a>:</h4>
<p>but hopefully <span class="user-mention" data-user-id="124288">@oli</span> 's work will make the debate moot</p>



<a name="166369086"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166369086" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166369086">(May 23 2019 at 15:02)</a>:</h4>
<p>now my question is: How did we not encounter this in our own test suite?</p>



<a name="166369089"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166369089" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166369089">(May 23 2019 at 15:02)</a>:</h4>
<p>Probably, but you also have to factor in that an ICE for erroring code is still a form of non-compilation while an ICE for non-erroring code is non-compliance with "the spec" from rustc's side</p>



<a name="166369113"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166369113" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166369113">(May 23 2019 at 15:02)</a>:</h4>
<blockquote>
<p>now my question is: How did we not encounter this in our own test suite?</p>
</blockquote>
<p>Yes. That is the best question!</p>



<a name="166369138"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166369138" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166369138">(May 23 2019 at 15:03)</a>:</h4>
<p>I'm sort of shocked tthat the example that <span class="user-mention" data-user-id="126931">@centril</span> came up with wasn't hit in our our source base and/or test suite. Maybe we don't use turbo-fish all that often ourselves?</p>



<a name="166369167"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166369167" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166369167">(May 23 2019 at 15:03)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span>  I think we often are shoddy with our testing</p>



<a name="166369175"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166369175" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166369175">(May 23 2019 at 15:03)</a>:</h4>
<p>yep</p>



<a name="166369208"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166369208" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166369208">(May 23 2019 at 15:03)</a>:</h4>
<p>We are optimistic with our input space partitioning and don't do combinatorial tests</p>



<a name="166369213"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166369213" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166369213">(May 23 2019 at 15:04)</a>:</h4>
<p>We're very _reactive_, with notable exceptions for _some_ new features.</p>



<a name="166369313"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166369313" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166369313">(May 23 2019 at 15:04)</a>:</h4>
<blockquote>
<p>with notable exceptions for _some_ new features.</p>
</blockquote>
<p>I hope for it to stay this way -- I'm going to try to require high test coverage for stabilizations.</p>



<a name="166369328"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166369328" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166369328">(May 23 2019 at 15:05)</a>:</h4>
<p>and start with high test coverage from the very start</p>



<a name="166371854"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166371854" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166371854">(May 23 2019 at 15:31)</a>:</h4>
<p>[I'm back]</p>



<a name="166376310"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166376310" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166376310">(May 23 2019 at 16:20)</a>:</h4>
<p><span class="user-mention" data-user-id="119009">@eddyb</span> how's going?</p>



<a name="166376335"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166376335" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166376335">(May 23 2019 at 16:20)</a>:</h4>
<p>/me stares at Zulip</p>



<a name="166376367"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166376367" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166376367">(May 23 2019 at 16:21)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> I got it working, will push in minute</p>



<a name="166376374"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166376374" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166376374">(May 23 2019 at 16:21)</a>:</h4>
<p><span aria-label="heart" class="emoji emoji-2764" role="img" title="heart">:heart:</span></p>



<a name="166376667"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166376667" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166376667">(May 23 2019 at 16:25)</a>:</h4>
<p><span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span></p>



<a name="166376807"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166376807" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166376807">(May 23 2019 at 16:26)</a>:</h4>
<p>done, how do we handle the review?</p>



<a name="166376917"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166376917" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166376917">(May 23 2019 at 16:28)</a>:</h4>
<p><span class="user-mention" data-user-id="124288">@oli</span> <span class="user-mention" data-user-id="121053">@varkor</span> <span class="user-mention" data-user-id="116083">@pnkfelix</span> any of you around for the review of <a href="https://github.com/rust-lang/rust/pull/61085" target="_blank" title="https://github.com/rust-lang/rust/pull/61085">https://github.com/rust-lang/rust/pull/61085</a>?</p>



<a name="166379156"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166379156" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166379156">(May 23 2019 at 16:56)</a>:</h4>
<p>yes, I'll do that now</p>



<a name="166379293"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166379293" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166379293">(May 23 2019 at 16:58)</a>:</h4>
<p>in it's current state, it's basically a partial revert of <a href="https://github.com/rust-lang/rust/pull/59025" target="_blank" title="https://github.com/rust-lang/rust/pull/59025">https://github.com/rust-lang/rust/pull/59025</a></p>



<a name="166379303"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166379303" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166379303">(May 23 2019 at 16:58)</a>:</h4>
<p>where <code>rewrite_self_ctor</code> still exists, but only does the <code>Def -&gt; Def</code> rewrite</p>



<a name="166379756"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166379756" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166379756">(May 23 2019 at 17:04)</a>:</h4>
<p>okay, it's being tested by bors now</p>



<a name="166379782"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166379782" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166379782">(May 23 2019 at 17:04)</a>:</h4>
<p><span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span></p>



<a name="166379790"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166379790" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166379790">(May 23 2019 at 17:04)</a>:</h4>
<p>thanks everybody for the quick fix!</p>



<a name="166379944"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166379944" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166379944">(May 23 2019 at 17:06)</a>:</h4>
<p>this will also need backporting to beta, right?</p>



<a name="166379959"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/ICE%20with%20incorrect%20turbofish%20%2360989/near/166379959" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/ICE.20with.20incorrect.20turbofish.20.2360989.html#166379959">(May 23 2019 at 17:06)</a>:</h4>
<p>yeah, and to master</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>